fix(license): correction to MIT + MIT-0 (no proprietary anymore) #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry generates license classifiers based on a [licenses.json@b5d1934](https://github.com/python-poetry/poetry-core/blob/b5d1934fed190bbfd1a303b44d5e2ef9a600efed/src/poetry/core/spdx/data/licenses.json). At the moment `MIT-0` is not recognized as an existing license and a `Classifier: License :: Other/Proprietary License` is added to the list of classifiers which leads to unexpected behavior from license checkers. Signed-off-by: Martin <[email protected]>
boring-cyborg
bot
added
the
dependencies
pull-request-size
bot
added
the
size/XS
e42sh
changed the title
Poetry generates license classifiers based on a [licenses.json@b5d1934](https://github.com/python-poetry/poetry-core/blob/b5d1934fed190bbfd1a303b44d5e2ef9a600efed/src/poetry/core/spdx/data/licenses.json). At the moment `MIT-0` is not recognized as an existing license and a `Classifier: License :: Other/Proprietary License` is added to the list of classifiers which leads to unexpected behavior from license checkers. Signed-off-by: Martin <[email protected]>
heitorlessa
changed the title
heitorlessa
approved these changes
Feb 1, 2023
|
This is a stellar contribution - thank you for linking the Poetry findings. Merging, and will be making a patch release within the next hour or so. |
Codecov ReportBase: 97.51% // Head: 97.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1883 +/- ##
========================================
Coverage 97.51% 97.51%
========================================
Files 143 143
Lines 6570 6570
Branches 466 466
========================================
Hits 6407 6407
Misses 128 128
Partials 35 35 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
heitorlessa
changed the title
heitorlessa
added a commit
to BakasuraRCE/aws-lambda-powertools-python
that referenced
this pull request
Feb 7, 2023
* develop: (24 commits) chore(deps): bump docker/setup-buildx-action from 2.4.0 to 2.4.1 (aws-powertools#1903) chore(deps-dev): bump aws-cdk-lib from 2.63.0 to 2.63.2 (aws-powertools#1904) update changelog with latest changes docs(idempotency): add IAM permissions section (aws-powertools#1902) chore(deps-dev): bump mkdocs-material from 9.0.10 to 9.0.11 (aws-powertools#1896) chore(deps-dev): bump mypy-boto3-appconfig from 1.26.0.post1 to 1.26.63 (aws-powertools#1895) chore(maintainers): fix release workflow rename update changelog with latest changes docs(homepage): set url for end-of-support in announce block (aws-powertools#1893) chore(deps-dev): bump mkdocs-material from 9.0.9 to 9.0.10 (aws-powertools#1888) chore(deps-dev): bump mypy-boto3-s3 from 1.26.58 to 1.26.62 (aws-powertools#1889) chore(deps-dev): bump black from 22.12.0 to 23.1.0 (aws-powertools#1886) chore(deps-dev): bump aws-cdk-lib from 2.62.2 to 2.63.0 (aws-powertools#1887) update changelog with latest changes feat(metrics): add default_dimensions to single_metric (aws-powertools#1880) chore: update v2 layer ARN on documentation bump version to 2.7.1 update changelog with latest changes docs(homepage): add banner for end-of-support v1 (aws-powertools#1879) fix(license): correction to MIT + MIT-0 (no proprietary anymore) (aws-powertools#1883) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poetry generates license classifiers based on a licenses.json@b5d1934.
At the moment
MIT-0is not recognized as an existing license and aClassifier: License :: Other/Proprietary Licenseis added to the list of classifiers which leads to unexpected behavior from license checkers.Signed-off-by: Martin [email protected]
Issue number:
Maintenance: Add header to LICENSE #1881
Summary
Changes
Updated poetry configuration.
User experience
License checkers should not complain about proprietary licenses. PyPi will signal a MIT and MIT-0 license instead of the proprietary license.
See current state:
Source https://pypi.org/project/aws-lambda-powertools/
The resulting PKG-INFO should look like
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
Yes. The PKG-INFO in the distribution package will change. The
Classifier: License :: Other/Proprietary Licenseclassifier will be removed and besides theClassifier: License :: OSI Approved :: MIT Licenseclassifier an additionalLicense :: OSI Approved :: MIT No Attribution License (MIT-0)will be added through the use of trove_classifiers.However, from my point of view, it should match with other distributions of the Lambda Power Tools, e.g. https://www.npmjs.com/package/@aws-lambda-powertools/metrics and should not raise any issues from other users, as the license becomes more relaxed.
However, when Poetry / Poetry Core will support MIT-0, this breaking change would implicitly occur without any notification.
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.